Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mandate '+' in all phoneNumber formats #148

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Mandate '+' in all phoneNumber formats #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8ad0c1
update guidelines, common and glossary to mandate phone number prefix…
fernandopradocabrillo Mar 1, 2024
53b8c36
fix regex to avoid leading zero
fernandopradocabrillo Mar 1, 2024
c3cc9ad
increase min length
fernandopradocabrillo Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions artifacts/CAMARA_common.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ components:
minProperties: 1

PhoneNumber:
description: A public identifier addressing a telephone subscription. In mobile networks it corresponds to the MSISDN (Mobile Station International Subscriber Directory Number). In order to be globally unique it has to be formatted in international format, according to E.164 standard, optionally prefixed with '+'.
description: A public identifier addressing a telephone subscription. In mobile networks it corresponds to the MSISDN (Mobile Station International Subscriber Directory Number). In order to be globally unique it has to be formatted in international format, according to E.164 standard, prefixed with '+'.
type: string
pattern: '^\+?[0-9]{5,15}$'
example: "123456789"
pattern: '^\+[1-9][0-9]{4,14}$'
example: "+123456789"

NetworkAccessIdentifier:
description: A public identifier addressing a subscription in a mobile network. In 3GPP terminology, it corresponds to the GPSI formatted with the External Identifier ({Local Identifier}@{Domain Identifier}). Unlike the telephone number, the network access identifier is not subjected to portability ruling in force, and is individually managed by each operator.
Expand Down
4 changes: 2 additions & 2 deletions documentation/API-design-guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1526,7 +1526,7 @@ curl -X 'POST' \
"data": {
"subscriptionId": "456g899g",
"device": {
"phoneNumber": 123456789
"phoneNumber": "+123456789"
},
"roaming": true,
"countryCode": 208,
Expand Down Expand Up @@ -1563,7 +1563,7 @@ curl -X 'POST' \
"data": {
"subscriptionId": "456g899g",
"device": {
"phoneNumber": 123456789
"phoneNumber": "+123456789"
},
"terminationReason": "SUBSCRIPTION_EXPIRED"
},
Expand Down
2 changes: 1 addition & 1 deletion documentation/Glossary.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
| ------------ | ----------- | ----------- | ----------- |
| **Device** |End-user equipment able to connect to a network. Examples of devices include smartphones, home gateways or IoT sensors/actuators. | device | | |
| **Application Server** | A server hosting backend applications to deliver some business logic to clients. | applicationServer | | |
| **Phone Number** |A public identifier addressing a telephone subscription. In mobile networks it corresponds to the MSISDN (Mobile Station International Subscriber Directory Number). In order to be globally unique it has to be formatted in international format, according to E.164 standard. | phoneNumber | | |
| **Phone Number** |A public identifier addressing a telephone subscription. In mobile networks it corresponds to the MSISDN (Mobile Station International Subscriber Directory Number). In order to be globally unique it has to be formatted in international format, according to E.164 standard, prefixed with '+'. | phoneNumber | | |
| **Network Access Identifier** | A public identifier addressing a subscription in a network, defined in [IETF RFC 7542](https://datatracker.ietf.org/doc/rfc7542/). In 3GPP mobile networks one such option is the General Public Subscriber Identifier (GPSI) formatted with the "External Identifier" as ({Local Identifier}@{Domain Identifier}). Unlike the phone number, the network access identifier is not subjected to portability ruling in force, and is individually managed by each operator. | networkAccessIdentifier | | |
| **IP v4 Address** | Identifier of a node in a network using Internet Protocol version 4 (IPv4). IPv4 uses 32-bit addresses, which are insufficient to allocate unique addresses to all current devices. In order to mitigate this, network operators use Network Address Translation (NAT), mapping a private IP address space to a public one. | ipv4Address | | |
| **IP v6 Address** | | ipv6Address | | | | |
Expand Down