Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CAMARA_common.yaml #124

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Update CAMARA_common.yaml #124

merged 2 commits into from
Jan 31, 2024

Conversation

RubenBG7
Copy link
Collaborator

Little typos bugs fixed

What type of PR is this?

Add one of the following kinds:

  • bug
  • correction
  • enhancement/feature
  • cleanup
  • documentation
  • subproject management
  • tests

What this PR does / why we need it:

  • correction
  • bug

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Unavailable:
description: Service Unavailable
content:
application/json:
schema:
$ref: "#/components/schemas/ErrorInfo"
example:
status: 503
code: UNAVAILABLE
message: Service Unavailable

AND

Timeout:
description: Timeout
content:
application/json:
schema:
$ref: "#/components/schemas/ErrorInfo"
example:
status: 504
code: TIMEOUT
message: Request timeout exceeded

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Little typos bugs fixed
patrice-conil
patrice-conil previously approved these changes Jan 23, 2024
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

jordonezlucena
jordonezlucena previously approved these changes Jan 23, 2024
Copy link
Collaborator

@jordonezlucena jordonezlucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Little fix on a Capital Letter to align with the rest of errors
Copy link
Collaborator

@jordonezlucena jordonezlucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

code: UNAVAILABLE
message: Request timeout exceeded
message: Service Unavailable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
message: Service Unavailable
message: Service unavailable

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to align with other error descriptions (capital letter the first word).
My fault as I commented to Ruben in a wrong way

@rartych rartych merged commit bf052ae into main Jan 31, 2024
@rartych rartych deleted the RubenBG7-patch-1 branch October 9, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants