API name change - from RegionUserCount to RegionDeviceCount #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinaunicomyangfan
requested review from
TEF-RicardoSerr,
jgarciahospital,
NoelWirzius and
caubut-charter
as code owners
|
Orange team supports this proposal discussed in the WG. |
TEF-RicardoSerr
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
As for last meeting (see minutes here) this PR can be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
After discussion in RUC work group, we believe that switch the API name from RegionUserCount to RegionDeviceCount is more accurate because operators can count the number of connected devices rather than the number of users. Specific discussions can refer to here