Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'react/renderer/components/rncore/EventEmitters.h' file not found #635

Closed
cjpete opened this issue Sep 9, 2024 · 3 comments · Fixed by #639
Closed

'react/renderer/components/rncore/EventEmitters.h' file not found #635

cjpete opened this issue Sep 9, 2024 · 3 comments · Fixed by #639
Assignees
Labels
bug report Something isn't working duplicate This issue or pull request already exists new architecture Issue relates to react-native new architecture

Comments

@cjpete
Copy link

cjpete commented Sep 9, 2024

Environment

  • react-native info output:
System:
  OS: macOS 14.5
  CPU: (12) arm64 Apple M2 Pro
  Memory: 126.92 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.18.2
    path: ~/.nvm/versions/node/v18.18.2/bin/node
  Yarn:
    version: 3.6.4
    path: ~/.nvm/versions/node/v18.18.2/bin/yarn
  npm:
    version: 9.8.1
    path: ~/.nvm/versions/node/v18.18.2/bin/npm
  Watchman: Not Found
Managers:
  CocoaPods: Not Found
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.0
      - iOS 17.0
      - macOS 14.0
      - tvOS 17.0
      - watchOS 10.0
  Android SDK:
    API Levels:
      - "30"
      - "31"
      - "33"
      - "34"
    Build Tools:
      - 30.0.3
      - 33.0.0
      - 33.0.1
      - 34.0.0
      - 35.0.0
    System Images:
      - android-34 | Google APIs ARM 64 v8a
      - android-35 | Google Play ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2024.1 AI-241.18034.62.2411.12071903
  Xcode:
    version: 15.0.1/15A507
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.12
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.75.2
    wanted: 0.75.2
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: true
  • are you using the new architecture? Yes

  • which version of react & react-native are you using? 18.3.1 / 0.75.2

Description

When using the new architecture with statically linked frameworks (required if using react-native-firebase for example), the iOS app won't compile.

/Users/christopherpitt/Development/TestNewArchitecture/node_modules/@react-native-community/slider/common/cpp/react/renderer/components/RNCSlider/RNCSliderShadowNode.h:4:10 'react/renderer/components/rncore/EventEmitters.h' file not found
image

If I remove that line, then the iOS app compiles and runs.

Reproducible Demo

https://github.com/72days/debug-new-arch-slider

When installing iOS pods, use new arch and static frameworks:

RCT_NEW_ARCH_ENABLED=1 USE_FRAMEWORKS=static bundle exec pod install
@cjpete cjpete added the bug report Something isn't working label Sep 9, 2024
@cjpete
Copy link
Author

cjpete commented Sep 9, 2024

diff --git a/node_modules/@react-native-community/slider/common/cpp/react/renderer/components/RNCSlider/RNCSliderShadowNode.h b/node_modules/@react-native-community/slider/common/cpp/react/renderer/components/RNCSlider/RNCSliderShadowNode.h
index 85b2ff9..b30099f 100644
--- a/node_modules/@react-native-community/slider/common/cpp/react/renderer/components/RNCSlider/RNCSliderShadowNode.h
+++ b/node_modules/@react-native-community/slider/common/cpp/react/renderer/components/RNCSlider/RNCSliderShadowNode.h
@@ -1,7 +1,6 @@
 #pragma once
 
 #include <jsi/jsi.h>
-#include <react/renderer/components/rncore/EventEmitters.h>
 #include <react/renderer/components/RNCSlider/RNCSliderState.h>
 #include <react/renderer/components/RNCSlider/Props.h>
 #include <react/renderer/components/RNCSlider/EventEmitters.h>

@draggie draggie self-assigned this Sep 11, 2024
@efstathiosntonas
Copy link

duplicate #631

@BartoszKlonowski BartoszKlonowski added duplicate This issue or pull request already exists new architecture Issue relates to react-native new architecture labels Sep 12, 2024
@BartoszKlonowski
Copy link
Member

Indeed this is a duplicate, let me close this one.
Thanks @efstathiosntonas for finding!

@BartoszKlonowski BartoszKlonowski closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Something isn't working duplicate This issue or pull request already exists new architecture Issue relates to react-native new architecture
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants