Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user import css instead #32

Closed
ScottEAdams opened this issue Oct 7, 2020 · 1 comment
Closed

Let user import css instead #32

ScottEAdams opened this issue Oct 7, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ScottEAdams
Copy link

Is your feature request related to a problem? Please describe.

I was hoping to test this out on nextjs but sadly it throws the error:

./node_modules/video.js/dist/video-js.css
Global CSS cannot be imported from within node_modules.
Read more: https://err.sh/next.js/css-npm
Location: node_modules/videojs-react-enhanced/dist/index.es.js

Describe the solution you'd like

In nextjs any global css must be loaded in _app.js so removing the video-js.css import would let me do so.

@ScottEAdams ScottEAdams added the enhancement New feature or request label Oct 7, 2020
@cadenzah
Copy link
Owner

cadenzah commented Oct 7, 2020

Thank you for reporting an issue for this library!

I see your point. I will remove the import of css in library, and let users import it themselves. It seems there isn't any reason to do it inside the library, and it will support better compatibility for use case like yours(Next.js).

+) Also will modify sample usage code on documentation

Reference

@cadenzah cadenzah self-assigned this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants