-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
squid:S00108 - Nested blocks of code should not be left empty #67
squid:S00108 - Nested blocks of code should not be left empty #67
Conversation
Thanks for the recommendations! A couple of things though:
|
Fixed. Thanks! If there is any issue please let me know. |
Could you make one commit out of this? The easiest way is to And do the same for the other other pull requests! Thanks |
159341f
to
8005a0e
Compare
Done Sir. |
Thanks! But there is still a problem with the "fail silently" part. It isn't supposed to report or log anything. Would you have a suggestion about how to make that fact clearer for all the types of exceptions thrown there, without repeating the comment three times, if possible? thanks! |
Any updates? |
Why not to catch general Exception not to repeat empty blocks 3 times or Java 7 multi catch clause can also be used. |
Multicatch is a good idea I think! It should have no problem on Android as well. |
8005a0e
to
7858f2e
Compare
Please take a loot at changes. Hope this is what was expected. |
Looks good, thanks! |
…de-should-not-be-left-empty-fix-1 Do at least something for exceptions we swallow but do not expect
This pull request is focused on resolving occurrences of Sonar rule squid:S00108 - Nested blocks of code should not be left empty.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS00108
Please let me know if you have any questions.
George Kankava