Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct generation of Vec4iVector #718

Closed
wants to merge 1 commit into from
Closed

Conversation

jpsacha
Copy link
Member

@jpsacha jpsacha commented Apr 19, 2019

Fix for #717

@saudet
Copy link
Member

saudet commented Apr 20, 2019

Actually, I don't think we need it there at all because it's already here: https://github.com/bytedeco/javacpp-presets/blob/master/opencv/src/main/java/org/bytedeco/opencv/presets/opencv_core.java#L360
Can you check that?

@jpsacha
Copy link
Member Author

jpsacha commented Apr 20, 2019

HoughLinesP is declared with Vec4iVector, see:

"@Namespace(\"cv\") public static native void HoughLinesP( @ByVal Mat image, @ByVal Vec4iVector lines,\n"

The line you pointed declares Scalar4i

.put(new Info("cv::Vec4i").pointerTypes("Scalar4i"))

It does not resolve issue with Vec4iVector/HoughLinesP

May be Vec4iVector should be deleted and HoughLinesP declared with Scalar4i?

@saudet
Copy link
Member

saudet commented Apr 20, 2019

Yes, but it should still work. Did you try to build it that way?

@jpsacha
Copy link
Member Author

jpsacha commented Apr 20, 2019

I do not rebuild it. I am using released versions.

@saudet
Copy link
Member

saudet commented Apr 21, 2019

Fixed in commit 03bc116, thanks for reporting!

@saudet saudet closed this Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants