Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV_CH_LAYOUT_ defines are int instead of long #455

Closed
ishitatsuyuki opened this issue Aug 28, 2017 · 4 comments
Closed

AV_CH_LAYOUT_ defines are int instead of long #455

ishitatsuyuki opened this issue Aug 28, 2017 · 4 comments

Comments

@ishitatsuyuki
Copy link
Contributor

They're weakly typed in C relying on the integer type auto conversion (and this applies to Java as well).

However, inside Kotlin this creates a problem as conversion must be explicit and it gives you a bad feeling to manually cast a constant.

@saudet
Copy link
Member

saudet commented Aug 29, 2017

That could easily be fixed, would like to give it a try?

@ishitatsuyuki
Copy link
Contributor Author

I have no experience with javacpp internals, can you give some hint?

@saudet
Copy link
Member

saudet commented Aug 29, 2017

There's already one specified on the line below, we could do the rest:
https://github.com/bytedeco/javacpp-presets/blob/master/ffmpeg/src/main/java/org/bytedeco/javacpp/presets/avutil.java#L58

@ishitatsuyuki
Copy link
Contributor Author

Got it, will open a PR when I get to my computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants