Skip to content

Commit

Permalink
* Fix -platform artifacts on JPMS by commenting out requires to An…
Browse files Browse the repository at this point in the history
…droid modules (issue #814 and pull #831)
  • Loading branch information
HGuillemet authored and saudet committed Dec 24, 2019
1 parent f748f1d commit d267926
Show file tree
Hide file tree
Showing 13 changed files with 49 additions and 48 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@

* Fix `-platform` artifacts on JPMS by commenting out requires to Android modules ([issue #814](https://github.com/bytedeco/javacpp-presets/issues/814) and ([pull #831](https://github.com/bytedeco/javacpp-presets/pull/831)))
* Include `timecode.h`, among other missing header files, in the `avutil` module of FFmpeg ([issue #822](https://github.com/bytedeco/javacpp-presets/issues/822))
* Map a few more inherited constructors missing from the presets for MKL-DNN and DNNL
* Make sure `clone()` actually returns new `PIX`, `FPIX`, or `DPIX` objects with presets for Leptonica
Expand Down
8 changes: 4 additions & 4 deletions artoolkitplus/platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,10 @@
<file>${project.build.directory}/${project.artifactId}.jar</file>
<moduleInfoSource>
module org.bytedeco.${javacpp.moduleId}.platform {
requires org.bytedeco.${javacpp.moduleId}.android.arm;
requires org.bytedeco.${javacpp.moduleId}.android.arm64;
requires org.bytedeco.${javacpp.moduleId}.android.x86;
requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
// requires org.bytedeco.${javacpp.moduleId}.android.arm;
// requires org.bytedeco.${javacpp.moduleId}.android.arm64;
// requires org.bytedeco.${javacpp.moduleId}.android.x86;
// requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.x86;
requires org.bytedeco.${javacpp.moduleId}.linux.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.armhf;
Expand Down
8 changes: 4 additions & 4 deletions chilitags/platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,10 @@
<file>${project.build.directory}/${project.artifactId}.jar</file>
<moduleInfoSource>
module org.bytedeco.${javacpp.moduleId}.platform {
requires org.bytedeco.${javacpp.moduleId}.android.arm;
requires org.bytedeco.${javacpp.moduleId}.android.arm64;
requires org.bytedeco.${javacpp.moduleId}.android.x86;
requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
// requires org.bytedeco.${javacpp.moduleId}.android.arm;
// requires org.bytedeco.${javacpp.moduleId}.android.arm64;
// requires org.bytedeco.${javacpp.moduleId}.android.x86;
// requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.x86;
requires org.bytedeco.${javacpp.moduleId}.linux.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.armhf;
Expand Down
8 changes: 4 additions & 4 deletions cpu_features/platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,10 @@
<file>${project.build.directory}/${project.artifactId}.jar</file>
<moduleInfoSource>
module org.bytedeco.${javacpp.moduleId}.platform {
requires org.bytedeco.${javacpp.moduleId}.android.arm;
requires org.bytedeco.${javacpp.moduleId}.android.arm64;
requires org.bytedeco.${javacpp.moduleId}.android.x86;
requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
// requires org.bytedeco.${javacpp.moduleId}.android.arm;
// requires org.bytedeco.${javacpp.moduleId}.android.arm64;
// requires org.bytedeco.${javacpp.moduleId}.android.x86;
// requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.x86;
requires org.bytedeco.${javacpp.moduleId}.linux.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.armhf;
Expand Down
8 changes: 4 additions & 4 deletions ffmpeg/platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,10 @@
<file>${project.build.directory}/${project.artifactId}.jar</file>
<moduleInfoSource>
module org.bytedeco.${javacpp.moduleId}.platform {
requires org.bytedeco.${javacpp.moduleId}.android.arm;
requires org.bytedeco.${javacpp.moduleId}.android.arm64;
requires org.bytedeco.${javacpp.moduleId}.android.x86;
requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
// requires org.bytedeco.${javacpp.moduleId}.android.arm;
// requires org.bytedeco.${javacpp.moduleId}.android.arm64;
// requires org.bytedeco.${javacpp.moduleId}.android.x86;
// requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.x86;
requires org.bytedeco.${javacpp.moduleId}.linux.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.armhf;
Expand Down
8 changes: 4 additions & 4 deletions fftw/platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,10 @@
<file>${project.build.directory}/${project.artifactId}.jar</file>
<moduleInfoSource>
module org.bytedeco.${javacpp.moduleId}.platform {
requires org.bytedeco.${javacpp.moduleId}.android.arm;
requires org.bytedeco.${javacpp.moduleId}.android.arm64;
requires org.bytedeco.${javacpp.moduleId}.android.x86;
requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
// requires org.bytedeco.${javacpp.moduleId}.android.arm;
// requires org.bytedeco.${javacpp.moduleId}.android.arm64;
// requires org.bytedeco.${javacpp.moduleId}.android.x86;
// requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.x86;
requires org.bytedeco.${javacpp.moduleId}.linux.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.armhf;
Expand Down
8 changes: 4 additions & 4 deletions flandmark/platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,10 @@
<file>${project.build.directory}/${project.artifactId}.jar</file>
<moduleInfoSource>
module org.bytedeco.${javacpp.moduleId}.platform {
requires org.bytedeco.${javacpp.moduleId}.android.arm;
requires org.bytedeco.${javacpp.moduleId}.android.arm64;
requires org.bytedeco.${javacpp.moduleId}.android.x86;
requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
// requires org.bytedeco.${javacpp.moduleId}.android.arm;
// requires org.bytedeco.${javacpp.moduleId}.android.arm64;
// requires org.bytedeco.${javacpp.moduleId}.android.x86;
// requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.x86;
requires org.bytedeco.${javacpp.moduleId}.linux.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.armhf;
Expand Down
8 changes: 4 additions & 4 deletions gsl/platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,10 @@
<file>${project.build.directory}/${project.artifactId}.jar</file>
<moduleInfoSource>
module org.bytedeco.${javacpp.moduleId}.platform {
requires org.bytedeco.${javacpp.moduleId}.android.arm;
requires org.bytedeco.${javacpp.moduleId}.android.arm64;
requires org.bytedeco.${javacpp.moduleId}.android.x86;
requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
// requires org.bytedeco.${javacpp.moduleId}.android.arm;
// requires org.bytedeco.${javacpp.moduleId}.android.arm64;
// requires org.bytedeco.${javacpp.moduleId}.android.x86;
// requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.x86;
requires org.bytedeco.${javacpp.moduleId}.linux.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.armhf;
Expand Down
8 changes: 4 additions & 4 deletions leptonica/platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,10 @@
<file>${project.build.directory}/${project.artifactId}.jar</file>
<moduleInfoSource>
module org.bytedeco.${javacpp.moduleId}.platform {
requires org.bytedeco.${javacpp.moduleId}.android.arm;
requires org.bytedeco.${javacpp.moduleId}.android.arm64;
requires org.bytedeco.${javacpp.moduleId}.android.x86;
requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
// requires org.bytedeco.${javacpp.moduleId}.android.arm;
// requires org.bytedeco.${javacpp.moduleId}.android.arm64;
// requires org.bytedeco.${javacpp.moduleId}.android.x86;
// requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.x86;
requires org.bytedeco.${javacpp.moduleId}.linux.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.armhf;
Expand Down
8 changes: 4 additions & 4 deletions openblas/platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,10 @@
<file>${project.build.directory}/${project.artifactId}.jar</file>
<moduleInfoSource>
module org.bytedeco.${javacpp.moduleId}.platform {
requires org.bytedeco.${javacpp.moduleId}.android.arm;
requires org.bytedeco.${javacpp.moduleId}.android.arm64;
requires org.bytedeco.${javacpp.moduleId}.android.x86;
requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
// requires org.bytedeco.${javacpp.moduleId}.android.arm;
// requires org.bytedeco.${javacpp.moduleId}.android.arm64;
// requires org.bytedeco.${javacpp.moduleId}.android.x86;
// requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
requires org.bytedeco.${javacpp.moduleId}.ios.arm64;
requires org.bytedeco.${javacpp.moduleId}.ios.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.x86;
Expand Down
8 changes: 4 additions & 4 deletions opencv/platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,10 @@
<moduleInfoSource>
module org.bytedeco.${javacpp.moduleId}.platform {
requires transitive org.bytedeco.${javacpp.moduleId};
requires org.bytedeco.${javacpp.moduleId}.android.arm;
requires org.bytedeco.${javacpp.moduleId}.android.arm64;
requires org.bytedeco.${javacpp.moduleId}.android.x86;
requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
// requires org.bytedeco.${javacpp.moduleId}.android.arm;
// requires org.bytedeco.${javacpp.moduleId}.android.arm64;
// requires org.bytedeco.${javacpp.moduleId}.android.x86;
// requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
requires org.bytedeco.${javacpp.moduleId}.ios.arm64;
requires org.bytedeco.${javacpp.moduleId}.ios.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.x86;
Expand Down
8 changes: 4 additions & 4 deletions tensorflow/platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,10 @@
<file>${project.build.directory}/${project.artifactId}.jar</file>
<moduleInfoSource>
module org.bytedeco.${javacpp.moduleId}.platform {
requires org.bytedeco.${javacpp.moduleId}.android.arm;
requires org.bytedeco.${javacpp.moduleId}.android.arm64;
requires org.bytedeco.${javacpp.moduleId}.android.x86;
requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
// requires org.bytedeco.${javacpp.moduleId}.android.arm;
// requires org.bytedeco.${javacpp.moduleId}.android.arm64;
// requires org.bytedeco.${javacpp.moduleId}.android.x86;
// requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.x86;
requires org.bytedeco.${javacpp.moduleId}.linux.x86_64;
requires org.bytedeco.${javacpp.moduleId}.macosx.x86_64;
Expand Down
8 changes: 4 additions & 4 deletions tesseract/platform/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,10 @@
<file>${project.build.directory}/${project.artifactId}.jar</file>
<moduleInfoSource>
module org.bytedeco.${javacpp.moduleId}.platform {
requires org.bytedeco.${javacpp.moduleId}.android.arm;
requires org.bytedeco.${javacpp.moduleId}.android.arm64;
requires org.bytedeco.${javacpp.moduleId}.android.x86;
requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
// requires org.bytedeco.${javacpp.moduleId}.android.arm;
// requires org.bytedeco.${javacpp.moduleId}.android.arm64;
// requires org.bytedeco.${javacpp.moduleId}.android.x86;
// requires org.bytedeco.${javacpp.moduleId}.android.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.x86;
requires org.bytedeco.${javacpp.moduleId}.linux.x86_64;
requires org.bytedeco.${javacpp.moduleId}.linux.armhf;
Expand Down

0 comments on commit d267926

Please sign in to comment.