Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace-log feature does not take effect after #7626 #7685

Closed
feilongjiang opened this issue Dec 14, 2023 · 1 comment
Closed

trace-log feature does not take effect after #7626 #7685

feilongjiang opened this issue Dec 14, 2023 · 1 comment

Comments

@feilongjiang
Copy link
Contributor

feilongjiang commented Dec 14, 2023

#7626 changed the cranelift-codegen features from default to host-arch in crates/cranelift/Cargo.toml.

Before this change, I could enable trace by adding trace-log to the features' default list in cranelift/codegen/Cargo.toml.

But now the old way doesn't work, trace-log should be added to crates/cranelift/Cargo.toml like this:

cranelift-codegen = { workspace = true, features = ["host-arch", "trace-log"] }

is that expected behavior?

@alexcrichton
Copy link
Member

This is expected behavior in that it's how Cargo features work, but not necessarily expected behavior in that's how things are expected to work. The best solution here would probably be to add a cranelift-trace-log feature to the wasmtime crate and thread that through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants