Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmtime::CoreDump::_serialize shouldn't need a generic T in its store #7083

Open
fitzgen opened this issue Sep 25, 2023 · 0 comments
Open

Comments

@fitzgen
Copy link
Member

fitzgen commented Sep 25, 2023

Follow up to #7078 (comment)

It is there because the method calls public APIs that require a store with a T but none of them actually use the T. For every pub fn foo<T> that is called, we could create a pub(crate) fn _foo without the T and then call those methods from _serialize and ultimately remove the T from _serialize.

This would make it so that calling wasmtime::CoreDump::serialize isn't monomorphized for every T in a store passed to it, which can help compile times when there is more than one T used in the program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@fitzgen and others