Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasmtime: Add a config knob to control the maximum number of stack frames captured in a backtrace #5052

Open
fitzgen opened this issue Oct 13, 2022 · 2 comments
Open

wasmtime: Add a config knob to control the maximum number of stack frames captured in a backtrace #5052

fitzgen opened this issue Oct 13, 2022 · 2 comments

Comments

@fitzgen
Copy link
Member

fitzgen commented Oct 13, 2022

Would make capturing a backtrace go from O(n) where n is the number of Wasm frames on the stack to constant time for some user-defined acceptable constant. Max frames could be set to zero to disable backtraces completely. Would subsume the current (and deprecated) Config::wasm_backtrace method.

Follow up to #5049.
@fitzgen
Copy link
Member Author

fitzgen commented Oct 13, 2022

cc @Stebalien

@fitzgen
Copy link
Member Author

fitzgen commented Oct 13, 2022

FWIW, last time I looked, V8 would only capture 20 stack frames in its JS error stacks. Relevant precedent.

@fitzgen fitzgen mentioned this issue Oct 13, 2022
Merged
@alexcrichton alexcrichton mentioned this issue Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fitzgen