Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmtime: CacheConfig should be seperated into Config and Cache #4257

Open
PureWhiteWu opened this issue Jun 10, 2022 · 1 comment
Open

wasmtime: CacheConfig should be seperated into Config and Cache #4257

PureWhiteWu opened this issue Jun 10, 2022 · 1 comment

Comments

@PureWhiteWu
Copy link
Contributor

Now the CacheConfig is used both as the config and the real cache, this is not the ideal way.

I'd propose to refactor this and make this two seperate parts.

@alexcrichton
Copy link
Member

It might be worth clarifying here that the caching system of Wasmtime hasn't really been touched much since it was first added to Wasmtime and isn't super well integrated with everything else. It predates most of the current API design so I think moving individual options to a Config like structure is likely a significant undertaking and I'm not sure that it's the best design to have.

In general I'm not sure how to configure the cache and ideally Wasmtime would be more flexible about its caching strategies to allow external implementations of caching rather than requiring a built-in one. Before refactoring the methods around Config here it may be better to see how features like #4155 will end up getting designed with Config or otherwise how they'll be configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants