Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of global.{set,get} with externref #1971

Open
alexcrichton opened this issue Jul 2, 2020 · 0 comments
Open

Improve performance of global.{set,get} with externref #1971

alexcrichton opened this issue Jul 2, 2020 · 0 comments
Labels
wasmtime Issues about wasmtime that don't fall into another label

Comments

@alexcrichton
Copy link
Member

First implemented in #1969 the easiest thing at the time was calling out to intrinsic functions to implement global.{get,set}, which means that there are no JIT fast paths for these operations. At the time of this writing there's no toolchain that uses global.{get,set} so we don't have a ton of motivation to make this fast, but I wanted to file this issue to make sure we don't forget about it and in case it comes up in the future!

For now it's likely safe to not worry about the performance here, but if this becomes a hot spot in the future this can be a point of coordination!

@alexcrichton alexcrichton added the wasmtime Issues about wasmtime that don't fall into another label label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime Issues about wasmtime that don't fall into another label
Projects
None yet
Development

No branches or pull requests

1 participant