Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampler pi and month array values #20

Open
benswick opened this issue Jul 12, 2018 · 1 comment
Open

Sampler pi and month array values #20

benswick opened this issue Jul 12, 2018 · 1 comment

Comments

@benswick
Copy link

benswick commented Jul 12, 2018

In slope_sampler_pi_samples_array the last element is { 10.0 * G_PI, "20π" } but the text should be "10π".

Should the last slope_sampler_month_samples_array element for December be "Dec"? Some languages abbreviate it Dez but they also abbreviate other months differently than English. I couldn't find a language that only abbreviates December differently.

@elvismt
Copy link
Collaborator

elvismt commented Jul 24, 2018

Thanks for openin this issue @benswick. These labels are currently hard coded when they shoud be dynamically generated and localized. Unfortunatelly, I am busy like crazy these days with my PhD thesis :( so I'll probably not gonna touch it for a while. Feel free to modify this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants