Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support json uplink configs #355

Merged
merged 3 commits into from
Sep 16, 2024
Merged

feat: support json uplink configs #355

merged 3 commits into from
Sep 16, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Aug 20, 2024

Closes #

Changes

Why?

update_uplink_config

Trials Performed

Started uplink with both toml and json versions of config, both work exactly as expected.

  1. Start uplink with config file without/unexpected extension:
Error: Auth file couldn't be loaded from "uplink.config"; supported file extensions: [`.json`,`.toml`]
  1. Start uplink with config.toml/config.json, observed that behavior is the same no matter JSON or TOML but it works

@de-sh de-sh requested a review from tekjar August 20, 2024 11:53
@de-sh de-sh merged commit af62cdb into main Sep 16, 2024
2 checks passed
@de-sh de-sh deleted the json-config branch September 16, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant