Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mark parallel actions as failed on restart #349

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fix: mark parallel actions as failed on restart #349

merged 2 commits into from
Jun 17, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jun 15, 2024

Closes #

Why?

  • Uplink loses track of all action status when network is down and uplink restarts
  • Uplink loses track of parallel actions on a restart

Trials Performed

Start uplink and trigger a launch_shell, restart uplink before the action reaches 100% progress
image

@de-sh de-sh requested a review from gautambt June 15, 2024 17:18
@de-sh de-sh merged commit 62f544a into main Jun 17, 2024
2 checks passed
@de-sh de-sh deleted the restart-actions branch June 17, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gautambt gautambt Awaiting requested review from gautambt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@de-sh