Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: continuous retry till timeout #294

Merged
merged 3 commits into from
Oct 10, 2023
Merged

fix: continuous retry till timeout #294

merged 3 commits into from
Oct 10, 2023

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Oct 10, 2023 •
edited
Loading

Closes #

Changes

Why?

Downloader retries should not be limited to 3 times, continuously retry till the download action is timedout

Trials Performed

 2023-10-10T16:59:01.368213Z  WARN uplink::collector::downloader: Retrying download; Continuing to download file from: bytes=0-33482

  2023-10-10T16:59:01.369021Z ERROR uplink::collector::downloader: Download failed: error sending request for url (https://firmware.stage.bytebeam.io/api/v1/file/60e38118-4541-470a-a1cf-5901d9757da4/artifact): error trying to connect: tcp connect error: Connection refused (os error 111)

  2023-10-10T16:59:02.371229Z  WARN uplink::collector::downloader: Retrying download; Continuing to download file from: bytes=0-33482

  2023-10-10T16:59:02.371601Z ERROR uplink::collector::downloader: Download failed: error sending request for url (https://firmware.stage.bytebeam.io/api/v1/file/60e38118-4541-470a-a1cf-5901d9757da4/artifact): error trying to connect: tcp connect error: Connection refused (os error 111)

  2023-10-10T16:59:03.372799Z  WARN uplink::collector::downloader: Retrying download; Continuing to download file from: bytes=0-33482

  2023-10-10T16:59:03.373657Z ERROR uplink::collector::downloader: Download failed: error sending request for url (https://firmware.stage.bytebeam.io/api/v1/file/60e38118-4541-470a-a1cf-5901d9757da4/artifact): error trying to connect: tcp connect error: Connection refused (os error 111)

  2023-10-10T16:59:04.374872Z  WARN uplink::collector::downloader: Retrying download; Continuing to download file from: bytes=0-33482

  2023-10-10T16:59:04.375549Z ERROR uplink::collector::downloader: Download failed: error sending request for url (https://firmware.stage.bytebeam.io/api/v1/file/60e38118-4541-470a-a1cf-5901d9757da4/artifact): error trying to connect: tcp connect error: Connection refused (os error 111)

  2023-10-10T16:59:05.376945Z  WARN uplink::collector::downloader: Retrying download; Continuing to download file from: bytes=0-33482

  2023-10-10T16:59:05.377787Z ERROR uplink::collector::downloader: Download failed: error sending request for url (https://firmware.stage.bytebeam.io/api/v1/file/60e38118-4541-470a-a1cf-5901d9757da4/artifact): error trying to connect: tcp connect error: Connection refused (os error 111)

  2023-10-10T16:59:06.378287Z  WARN uplink::collector::downloader: Retrying download; Continuing to download file from: bytes=0-33482

  2023-10-10T16:59:06.379031Z ERROR uplink::collector::downloader: Download failed: error sending request for url (https://firmware.stage.bytebeam.io/api/v1/file/60e38118-4541-470a-a1cf-5901d9757da4/artifact): error trying to connect: tcp connect error: Connection refused (os error 111)

  2023-10-10T16:59:07.380512Z  WARN uplink::collector::downloader: Retrying download; Continuing to download file from: bytes=0-33482

  2023-10-10T16:59:07.381807Z ERROR uplink::collector::downloader: Download failed: error sending request for url (https://firmware.stage.bytebeam.io/api/v1/file/60e38118-4541-470a-a1cf-5901d9757da4/artifact): error trying to connect: tcp connect error: Connection refused (os error 111)

  2023-10-10T16:59:08.383052Z  WARN uplink::collector::downloader: Retrying download; Continuing to download file from: bytes=0-33482

  2023-10-10T16:59:08.383917Z ERROR uplink::collector::downloader: Download failed: error sending request for url (https://firmware.stage.bytebeam.io/api/v1/file/60e38118-4541-470a-a1cf-5901d9757da4/artifact): error trying to connect: tcp connect error: Connection refused (os error 111)

  2023-10-10T16:59:09.385353Z  WARN uplink::collector::downloader: Retrying download; Continuing to download file from: bytes=0-33482

  2023-10-10T16:59:09.386617Z ERROR uplink::collector::downloader: Download failed: error sending request for url (https://firmware.stage.bytebeam.io/api/v1/file/60e38118-4541-470a-a1cf-5901d9757da4/artifact): error trying to connect: tcp connect error: Connection refused (os error 111)

  2023-10-10T16:59:10.387427Z  WARN uplink::collector::downloader: Retrying download; Continuing to download file from: bytes=0-33482

  2023-10-10T16:59:10.388942Z ERROR uplink::collector::downloader: Download failed: error sending request for url (https://firmware.stage.bytebeam.io/api/v1/file/60e38118-4541-470a-a1cf-5901d9757da4/artifact): error trying to connect: tcp connect error: Connection refused (os error 111)

  2023-10-10T16:59:11.390228Z  WARN uplink::collector::downloader: Retrying download; Continuing to download file from: bytes=0-33482

  2023-10-10T16:59:11.390636Z ERROR uplink::collector::downloader: Download failed: error sending request for url (https://firmware.stage.bytebeam.io/api/v1/file/60e38118-4541-470a-a1cf-5901d9757da4/artifact): error trying to connect: tcp connect error: Connection refused (os error 111)

  2023-10-10T16:59:12.392185Z  WARN uplink::collector::downloader: Retrying download; Continuing to download file from: bytes=0-33482

  2023-10-10T16:59:12.393441Z ERROR uplink::collector::downloader: Download failed: error sending request for url (https://firmware.stage.bytebeam.io/api/v1/file/60e38118-4541-470a-a1cf-5901d9757da4/artifact): error trying to connect: tcp connect error: Connection refused (os error 111)

@de-sh de-sh marked this pull request as ready for review October 10, 2023 16:59
@de-sh de-sh merged commit 33228f6 into main Oct 10, 2023
2 checks passed
@de-sh de-sh deleted the forever-retry branch October 10, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@de-sh