fix(rumqttc): Lower the MSRV to Rust version 1.64.0 #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried cargo-msrv and it is giving: can you just verify once 🤔 |
|
It looks like addr2line sets their MSRV to 1.65, but it can be compiled with 1.64. I'm not certain what the best practice is here, but surely rumqttc should follow its dependencies? |
|
lets rely on cargo msrv for this case :) |
RoastVeg
changed the title
swanandx
approved these changes
Dec 6, 2023
|
Thanks for contributing 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lowers the MSRV of rumqttc to rust version 1.64.0, as reported by
cargo-msrv. Everything still compiles and tests pass ok. rumqttd's MSRV is unchanged.Type of change
Bug fix (non-breaking change which fixes an issue)
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.