Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: docker image based on distroless & build and docker scripts #673

Closed
wants to merge 3 commits into from

Conversation

carlocorradini
Copy link
Contributor

Related to PR #671

What has been changed:

  • rumqttd Docker image is based on distroless rather than Alpine
    Docker image is now based on gcr.io/distroless/cc (from Google) to enhance overall security since "it does not contain package managers, shells or any other programs you would expect to find in a standard Linux distribution"

  • More robust and fully configurable scripts (see scripts and rumqttd/scripts directories). Also POSIX compliant

    1. rumqttd/scripts/docker.sh
      Build and push rumqttd Docker image
    2. rumqttd/scripts/build.sh
      Build rumqttd using Cross

    Note that both scripts are configurable and also have an helper flag (--help)

@carlocorradini
Copy link
Contributor Author

@de-sh Any update? 🤗🥳

@carlocorradini
Copy link
Contributor Author

@swanandx @henil Any thoughts on this? I apologize for pinging

@h3nill
Copy link

h3nill commented Sep 29, 2023

i think the script is very complicated and i am not sure that its really necessary. and for distroless docker image what are the advantage to use those instead of what we have currently?

@carlocorradini
Copy link
Contributor Author

I believe the numerous papers on Distroless vs Alpine can explain it far better than I can.😂😅
See this or this or ...

@carlocorradini
Copy link
Contributor Author

These scripts are quite user-friendly (with --help and args configuration) and POSIX compliant

@carlocorradini
Copy link
Contributor Author

The main parts are a few lines of code:

build.sh
image

docker.sh
image

Easy peasy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants