-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rumqttc: Add bind_device to NetworkOptions to enable TCPSocket.bind_device() #654
rumqttc: Add bind_device to NetworkOptions to enable TCPSocket.bind_device() #654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else LGTM, but can you explain the use case for this?
It can be used to force the connection to go via a specific network which may not be the default route. I would like to use it to maintain two independent connections to a server. I can verify the backup network route's connectivity while the primary (default) route is still active. |
539f841
to
e57156b
Compare
e57156b
to
267cb87
Compare
What's the latest with this PR @henil - it seems to have stalled. Is there anything more I can do? |
Hey, sorry for the delay. we have backlog of things to review and merge but we dont have enough bandwidth. I will try to get this reviewed and merged by this month. |
…bind_device() Signed-off-by: Seimon Williams <seimon@mobot.uk.com>
267cb87
to
07e2756
Compare
No worries - I noticed that clippy in the workflow didn't like the |
Thank you @seimonw! 🎉 |
Allows the network connection to be optionally bound to a specific interface.
See also: https://docs.rs/tokio/latest/tokio/net/struct.TcpSocket.html#method.bind_device
Type of change
New feature (non-breaking change which adds functionality)
Checklist:
cargo fmt
CHANGELOG.md
if its relevant of user of the library. If its not relevant mention why.