Disable unsused features from flume
dependency
#653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the dependency on
flume
to only enable itsasync
feature instead of all features that are enabled by default. The motivation for this change is that neitherrumqttc
norrumqttd
need to select between (i.e., wait for any one of multiple) messages from multiple channels. However, theselect
feature offlume
is enabled by default, together with itseventual-fairness
feature that ensures that channels in a selector cannot make other ones starve. To do so, a source of randomness is required which is obtained through additional dependencies that this PR aims to avoid for both users and developers ofrumqtt
.Type of change
Miscellaneous (related to maintanance)
Checklist:
cargo fmt
(onlyCargo.toml
s are changed)CHANGELOG.md
if its relevant of user of the library. If its not relevant mention why.