Topic alias and message expiry support in broker #616

swanandx · 2023-05-13T04:44:18Z

This PR adds support for MQTTv5 related features, topic alias and message expiry.

Topic alias

Allow clients to set and use topic alias
Broker can also set topic alias ( if supported by client ). If client specifies maximum topic alias to use, broker will use topic aliases for that client.

Message Expiry

Discard expired messages ( expired messaged mean time spent waiting >= message expiry interval )
before forwarding publish packets, update message expiry interval to original value - time spent

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

Formatted with cargo fmt
Make an entry to CHANGELOG.md if its relevant of user of the library. If its not relevant mention why.

…waiting

rumqttd/src/router/routing.rs

rumqttd/src/router/connection.rs

rumqttd/src/router/mod.rs

rumqttd/src/router/logs.rs

… explicitly

rumqttd/src/router/routing.rs

rumqttd/src/link/remote.rs

rumqttd/src/router/connection.rs

rumqttd/src/router/logs.rs

rumqttd/src/router/mod.rs

rumqttd/src/router/routing.rs

h3nill

i don't really like that fact that we are deriving the fact if a particular client is a v4 or v5 from assumptions and if some variable are Some or None. But i think that's the best we can do with current design.

left one small comment other than that LGTM.

rumqttd/src/router/routing.rs

* feat: store properties and expiry in logs * feat: ignore expired messages * fix: checking expired messages * feat: broker handling topic alias * feat: set message expiry interval to received value minus time spent waiting * fix: case when time spent is equal to message expiry interval * feat: broker can set topic alias for clients to use * feat: send disconnet packets to client * feat: using let-else instead of if-let * feat: entry in CHANGELOG * fix: declare topic in outer scope * fix: missing argument for Link * feat: include Reason in disconnection message * feat: handle tenant prefix properly while forwarding, check max_alias explicitly * feat: make broker_topic_alias optional * feat: validate and set topic alias in separate fn * feat: comments regarding last will and storage * feat: extract all broker topic alias related things to separate struct * feat: improve readability for message expiry * feat: typos and todo * feat: ignore connack properties in v4 * feat: rename topic_alias_exists to topic_alias_already_exists

swanandx added 12 commits May 8, 2023 10:32

feat: store properties and expiry in logs

7553031

feat: ignore expired messages

6baf993

fix: checking expired messages

e160b74

feat: broker handling topic alias

686b17b

feat: set message expiry interval to received value minus time spent …

e47d07e

…waiting

fix: case when time spent is equal to message expiry interval

9675fe2

feat: broker can set topic alias for clients to use

d95f0d1

feat: send disconnet packets to client

a9c269a

feat: using let-else instead of if-let

0587033

feat: entry in CHANGELOG

a6a5008

fix: declare topic in outer scope

65ef8b7

fix: missing argument for Link

37e9aa0

swanandx mentioned this pull request May 18, 2023

MQTTv5 support in rumqttd #621

Open

19 tasks

mnpw reviewed May 19, 2023

View reviewed changes

swanandx added 3 commits May 19, 2023 21:06

feat: include Reason in disconnection message

659c394

feat: handle tenant prefix properly while forwarding, check max_alias…

0bd88fc

… explicitly

feat: make broker_topic_alias optional

a026f1f

mnpw reviewed May 22, 2023

View reviewed changes

rumqttd/src/router/routing.rs Outdated Show resolved Hide resolved

swanandx added 3 commits May 22, 2023 16:44

feat: validate and set topic alias in separate fn

8b9b380

feat: comments regarding last will and storage

1bee7c0

feat: extract all broker topic alias related things to separate struct

6f9800a

h3nill reviewed May 22, 2023

View reviewed changes

rumqttd/src/router/routing.rs Outdated Show resolved Hide resolved

feat: improve readability for message expiry

a49f1b2

mnpw reviewed May 22, 2023

View reviewed changes

rumqttd/src/router/routing.rs Show resolved Hide resolved

h3nill reviewed May 23, 2023

View reviewed changes

swanandx added 2 commits May 23, 2023 18:59

feat: typos and todo

9216729

feat: ignore connack properties in v4

4a09d96

h3nill reviewed May 26, 2023

View reviewed changes

rumqttd/src/router/routing.rs Outdated Show resolved Hide resolved

feat: rename topic_alias_exists to topic_alias_already_exists

0539166

mnpw merged commit 7a4b895 into main May 29, 2023

swanandx deleted the tame branch July 28, 2023 09:11

swanandx mentioned this pull request Jan 4, 2024

rumqttd: disconnect notification does not fire for non-graceful disconnects. #775

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Topic alias and message expiry support in broker #616

Topic alias and message expiry support in broker #616

swanandx commented May 13, 2023

h3nill left a comment •

edited

Loading

Topic alias and message expiry support in broker #616

Topic alias and message expiry support in broker #616

Conversation

swanandx commented May 13, 2023

Topic alias

Message Expiry

Type of change

Checklist:

h3nill left a comment • edited Loading

Choose a reason for hiding this comment

h3nill left a comment •

edited

Loading