Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward TLS implementation selection to reqwest #488

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

flxo
Copy link
Contributor

@flxo flxo commented Oct 24, 2022

The TLS implementation is selected by either feature use-rustls or use-native-tls. The selection of the TLS implementation is forwarded to the request dependency which otherwise defaults to native-tls.

The TLS implementation is selected by either feature `use-rustls` or
`use-native-tls`. The selection of the TLS implementation is forwarded
to the `request` dependency which otherwise defaults to `native-tls`.
@flxo flxo changed the title Forward TLS implenentation selection to reqwest Forward TLS implementation selection to reqwest Oct 24, 2022
@flxo
Copy link
Contributor Author

flxo commented Oct 24, 2022

CI fails with

 ---- some_outgoing_and_no_incoming_should_trigger_pings_on_time stdout ----
Polled = Ok(Incoming(ConnAck(ConnAck { session_present: false, code: Success })))
Polled = Ok(Outgoing(Publish(0)))
Polled = Ok(Outgoing(Publish(0)))
Polled = Ok(Outgoing(Publish(0)))
Polled = Ok(Outgoing(Publish(0)))
Polled = Ok(Outgoing(Publish(0)))
Polled = Ok(Outgoing(PingReq))
Polled = Ok(Outgoing(Publish(0)))
Polled = Ok(Incoming(PingResp))
Polled = Ok(Outgoing(Publish(0)))
Polled = Ok(Outgoing(Publish(0)))
Polled = Ok(Outgoing(Publish(0)))
Polled = Ok(Outgoing(Publish(0)))
Polled = Ok(Outgoing(PingReq))
Polled = Err(MqttState(AwaitPingResp))
thread 'some_outgoing_and_no_incoming_should_trigger_pings_on_time' panicked at 'called `Result::unwrap()` on an `Err` value: MqttState(AwaitPingResp)', rumqttc/tests/reliability.rs:133:42
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'some_outgoing_and_no_incoming_should_trigger_pings_on_time' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: ConnectionAborted, error: "connection closed by peer" }', rumqttc/tests/broker.rs:154:24

which is probably unrelated to this PR and a flaky test. Can someone retrigger please?

@de-sh de-sh merged commit c93afb0 into bytebeamio:main Oct 26, 2022
@de-sh
Copy link
Contributor

de-sh commented Oct 26, 2022

Thanks for the PR @flxo 💯

@de-sh
Copy link
Contributor

de-sh commented Oct 27, 2022

Hey @flxo, we have discovered that rumqttd no longer depends on reqwest, can you give us an idea of what was your usecase for which you had to make the changes included in this PR?

@flxo
Copy link
Contributor Author

flxo commented Oct 27, 2022

@de-sh I tried to build rumqttd for aarch64-linux-android with a cross container that doesn't include openssl. I turned off default features because I don't need TLS. Turned out that the reqwest dependency depended on native-tls.

Your're right. reqwest is not used anymore - should be fine to just remove it from the manifest of rumqttd.

carlocorradini pushed a commit to carlocorradini/rumqtt that referenced this pull request Aug 3, 2023
The TLS implementation is selected by either feature `use-rustls` or
`use-native-tls`. The selection of the TLS implementation is forwarded
to the `request` dependency which otherwise defaults to `native-tls`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants