Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MqttOptions::parse_url uses rustls-native-certs::load_native_certs() for encrypted connections #436

Merged
merged 6 commits into from
Aug 26, 2022

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Aug 25, 2022

fixes #435

Changelog

  • MqttOptions::parse_url when passed the url for an encrypted protocol, e.g. mqtts://, ssl:// or wss:// will from now on use rustls-native-certs::load_native_certs() to load the certificates from the native cert store.
  • Updated documentation

@tekjar
Copy link
Contributor

tekjar commented Aug 25, 2022

On a different note, can we use system certificates to establish secure connection by default. It can always be overridden using Transport constructs?

@de-sh de-sh changed the title doc: add note about MqttOptions::parse_url and Transport for encrypted connections feat: MqttOptions::parse_url uses rustls-native-certs::load_native_certs() for encrypted connections Aug 26, 2022
@de-sh de-sh merged commit 4935b9d into master Aug 26, 2022
@de-sh de-sh deleted the doc branch August 26, 2022 06:41
carlocorradini pushed a commit to carlocorradini/rumqtt that referenced this pull request Aug 3, 2023
…_certs()` for encrypted connections (bytebeamio#436)

* `MqttOptions::parse_url` when passed the url for an encrypted protocol, e.g. `mqtts://`, `ssl://` or `wss://` will from now on use `rustls-native-certs::load_native_certs()` to load the certificates from the native cert store.

* Updated documentation

Issue: bytebeamio#435 

Attribute: @de-sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse_url does not handle ssl/tls like document implies
2 participants