feat: remove ability to cancel EventLoop.poll() mid execution
#421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tekjar shall I remove code associated with |
Signed-off-by: Devdutt Shenoi <devdutt@bytebeam.io>
de-sh
changed the title
AsyncClient::cancel()EventLoop.poll() mid execution
Closed
carlocorradini
pushed a commit
to carlocorradini/rumqtt
that referenced
this pull request
Aug 3, 2023
…beamio#421) Removes the ability for users to cancel requests while they are being polled within the `EventLoop`. BREAKING: `AsynClient::cancel()` removed Reasoning: This feature was deemed to be overkill and hence good to get rid of. Changes: * Remove `AsyncClient::cancel()` * Remove `ClientError::Cancel` variant * Strip out cancelability from `EventLoop` * Remove mentions of cancellation as a feature * docs: add changelog entry Signed-off-by: Devdutt Shenoi <devdutt@bytebeam.io> Attribute: @de-sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the ability for users to cancel requests while they are being polled within the
EventLoop. This feature was deemed to be overkill and hence good to get rid of.CC @tekjar