-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Somfy Tahoma plugin #454
Somfy Tahoma plugin #454
Conversation
Cool! Thanks will be pulling in for the next release. |
Taking a very, very quick look, I see that you are creating another HTTP client. I was trying to always use the HTTPHandler for this as to not have multiple places for http client code. What are your thoughts? |
Good plan - updated accordingly. Thanks for the feedback,
|
Did some review here, so for the JSON usage when getting the info, it would be best just to have a pojo with only the fields that are needed to extract that information. This becomes unwieldy if the interface changes from Somfy. |
Meged to latest master and cleaned up the json->pojo mappings as suggested - thanks!
|
Yes, that looks much better. I assume you have the Somfy blinds and testing works as expected. I will merge this in and then put it in the next release. |
New connectors3.1 Fixes #454 Somfy Tahoma plugin enhancement Fixes #430 hex value needed for dimming enhancement question Fixes #423 Naming & Notes Enhancement Suggestions enhancement Fixes #512 Dim handling in V4 question Fixes #467 Available syntaxes besides ${intensity.percent} ? enhancement Fixes #416 Use ${intensity.percent} with Harmony Hub enhancement question Fixes #548 Removing Delay or Repeat in Edit-Device results in bad Config bug Fixes #537 Minor documentation error bug Fixes #237 Upgrade resulted in duplicates - Need to keep ha-bridge created user for device enhancement question Fixes #324 Added a optional webhook for harmony-activity changes enhancement Fixes #492 Use relative path in URLs enhancement
Hi,
Many thanks for creating this bridge - it works beautifully in our Alexa'd house. I've added a plugin to support devices that can be controlled from a Somfy Tahoma box (this allows communication over IO-Homecontrol which is the protocol used by Velux windows and blinds). Only caveat is I have to ask 'turn on bathroom window' to open it:)
This is my first pull request on GitHub, so apologies if I've gone against convention in any way.
Many thanks,