Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isScrollingOptOut prop options + rename #1139

Closed
wuweiweiwu opened this issue Jun 15, 2018 · 1 comment
Closed

isScrollingOptOut prop options + rename #1139

wuweiweiwu opened this issue Jun 15, 2018 · 1 comment
Labels
enhancement

Comments

@wuweiweiwu
Copy link
Contributor

the current approach is tricky, if we user custom cellRangeRenderer, we probably omit that opt out, I'd suggest we can simply pass isScrolling = undefined when calling cellRangeRenderer if isScrollingOptOut is true, BTW I prefer the term usingIsScrolling from react-window

follow up to #1131
@wuweiweiwu
Copy link
Contributor Author

Upon further thought. The point of the isScrollingOptOut is to not rerender cells on scroll end. Thus calling it with a value of undefined would mean that we are still calling cellRenderer

cc: @nihgwu: what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wuweiweiwu