Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tokenize() function shouldn't split sentences on abbreviations like Dr. Fahad, Mr. Wayne etc #1

Open
burhanharoon opened this issue Mar 21, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@burhanharoon
Copy link
Owner

Right now the tokenize() function is splitting whenever a ' . ' character is found. Most of the time it's a correct approach to split a fine into sentences but sometimes the abbreviation like Dr., Mr., Mrs, etc. appear in a middle of a sentence and hence splits the sentence right there. I want to enhance the regex to not to spit the sentences on abbreviations.

@burhanharoon burhanharoon added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 21, 2022
@DaudAhmad0303
Copy link

Please assign this issue to me

@burhanharoon
Copy link
Owner Author

@DaudAhmad0303 Do you still want to work on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants