Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Refactor NRemover #16

Open
tkchafin opened this issue May 2, 2024 · 0 comments
Open

Discussion: Refactor NRemover #16

tkchafin opened this issue May 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@tkchafin
Copy link
Collaborator

tkchafin commented May 2, 2024

I wonder if it might make better sense to re-structure all of the Nremover functions as GenotypeData methods? In each case could either modify in-place or return a deep copy of current GenoData object.

This would allow us to be more flexible with the order of operations, for example a user could do GenoData.filterPop(..).filterInd(...) or GenoData.filter(miss=0.5).filter(Mac=2).filterInd(0.5) etc, so you could chain operations similarly to how you might do with a pandas dataframe?

Could include a logging module to track what order operations were done, which filters applied/ data removed at each step, so the sankey plot would still work?

@tkchafin tkchafin added the enhancement New feature or request label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant