NAVI31 was not detected properly due to a typo. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update device_description.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to compile the TensorFlow for my RX 7900XTX and found that a typo in device_description.h was preventing it from detecting the card properly. With this fix, TF now detects my graphics card.
I'm sure there are other issues that need to be addressed before 7900 series works properly. But I wanted to bring this to the developer's attention.
So far, I got a Stable Defusion (https://gist.github.com/BloodBlight/0d36b33d215056395f34db26fb419a63) and an LLM (https://blog.mlc.ai/2023/08/09/Making-AMD-GPUs-competitive-for-LLM-inference) working on my 7900 and want to get FT working as well. It seems AMD is getting close to supporting all the popular ML models soon.