Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unittest optional for python3.5+ #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make unittest optional for python3.5+ #57

wants to merge 1 commit into from

Conversation

jonringer
Copy link

@jonringer jonringer commented Jan 11, 2022 •
edited
Loading

unittest2 is an unmaintained backport package. Should be conditionally added

closes: #54

@jonringer jonringer mentioned this pull request Jan 11, 2022
Merged
13 tasks
@tjni tjni mentioned this pull request Nov 21, 2022
Merged
13 tasks
musicinmybrain
musicinmybrain reviewed Sep 12, 2024
View reviewed changes
tests/test_deprecation.py
try:
import unittest2
except ImportError:
import unittest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could write this more concisely as import unittest as unittest2.

@musicinmybrain
Copy link

The use of unittest2 in docs/sample.py can also be made conditional.

deprecation/docs/sample.py

Line 1 in 2a0ec07

import unittest2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musicinmybrain musicinmybrain musicinmybrain left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.1.0: test suite is usnig unittest2
2 participants
@jonringer @musicinmybrain