This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Use custom versions of electron-squirrel-startup and electron-winstaller #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use forked version of two Windows installation modules * Do not re-create shortcuts on the desktop on auto-update Auditors: @bbondy, @alexwykoff Test plan: This change can only be tested via an auto-update Scenario 1 i) Install older version of browser ii) Remove shortcut from desktop iii) Do an auto-update iV) Ensure the shortcut was not created Scenario 2 i) Install older version of browser ii) Do NOT remove shortcut from desktop iii) Do an auto-update iv) Ensure the shortcut opens the most recent version of the browser Fixes: #1181
|
++ thanks for doing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors: @bbondy, @alexwykoff
Test plan:
This change can only be tested via an auto-update
Scenario 1
i) Install older version of browser
ii) Remove shortcut from desktop
iii) Do an auto-update
iV) Ensure the shortcut was not created
Scenario 2
i) Install older version of browser
ii) Do NOT remove shortcut from desktop
iii) Do an auto-update
iv) Ensure the shortcut opens the most recent version of the browser
Fixes: #1181