Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Delete bookmark folder won't delete its child items #4124

Closed
darkdh opened this issue Sep 20, 2016 · 0 comments · Fixed by #4127
Closed

Delete bookmark folder won't delete its child items #4124

darkdh opened this issue Sep 20, 2016 · 0 comments · Fixed by #4127
Assignees
@darkdh
Labels
feature/bookmarks QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.2dev

Comments

@darkdh
Copy link
Member

darkdh commented Sep 20, 2016 •
edited
Loading

Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
After deleting bookmarks folder, the child items under it remain existed in bookmarks
Expected behavior:

  • Platform (Win7, 8, 10? macOS? Linux distro?): any
  • Brave Version: master @6e628fb7e9a3e21b615bcb6ca7323f11a0fb84fc
  • Steps to reproduce:
    1. Create a folder test under bookmark toolbar
    2. add twitter.com to bookmarks under test
    3. delete test
    4. twitter.com is still starred
  • Screenshot if needed:
  • Any related issues: This should be the root cause of Deleted bookmarks under folder shows up in URL suggestion #3763

CC @bsclifton
@darkdh darkdh self-assigned this Sep 20, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Sep 20, 2016
@darkdh
removeSite should also remove its children
036effa 
fix brave#3763
fix brave#4124

Auditors: @bsclifton

Test Plan:
1. Add folder "folder1" under bookmarks toolbar
2. Add folder "folder2" under "folder1"
3. Bookmark "facebook.com" and put it under "folder1"
4. Bookmark "twitter.com" and put it under "folder2"
5. Delete "folder1"
6. "facebook.com" and "twitter.com" should be unstarred
@darkdh darkdh mentioned this issue Sep 20, 2016
Merged
4 tasks
@darkdh darkdh added this to the 0.12.2dev milestone Sep 20, 2016
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Sep 23, 2016
Closed
This was referenced Sep 24, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/bookmarks QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.2dev
Development

Successfully merging a pull request may close this issue.

removeSite should also remove its children darkdh/browser-laptop
4 participants
@alexwykoff @luixxiul @darkdh @srirambv