Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Page title getting picked from Bookmarks rather than the page itself #4029

Closed
srirambv opened this issue Sep 15, 2016 · 0 comments
Closed

Page title getting picked from Bookmarks rather than the page itself #4029

srirambv opened this issue Sep 15, 2016 · 0 comments
Assignees
@bsclifton
Labels
feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.2dev

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Page title getting picked from Bookmarks rather than the page itself

Expected behavior:
Page Title should be taken from the webpage itself

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.1 RC2(Clean Install)
  • Steps to reproduce:
    1. Bookmark few pages
    2. Clear history to remove entries
    3. Edit bookmarks and rename the title
    4. Visit each bookmark
    5. History shows the edited names in title rather than the page title itself
  • Screenshot if needed:
    1
  • Any related issues:

cc: @bsclifton

Setting milestone as 0.12.1 for now.
@srirambv srirambv added this to the 0.12.1dev milestone Sep 15, 2016
@diracdeltas diracdeltas modified the milestones: 0.12.2dev, 0.12.1dev Sep 15, 2016
@bsclifton bsclifton self-assigned this Sep 16, 2016
@bsclifton bsclifton mentioned this issue Sep 16, 2016
Merged
4 tasks
MKuenzi pushed a commit to MKuenzi/browser-laptop that referenced this issue Sep 18, 2016
@bsclifton @MKuenzi
- History now uses title (not custom title)
f93572e 
- History page also uses cursor: default, to look more app-like

Fixes brave#4029

Auditors: @bbondy @srirambv

Test Plan:

Part 1
1. Visit https://clifton.io/about/
2. Bookmark the site; set the title to "TESTING 123"
3. Bring up the history page (Ctrl+Y / Cmd+Y)
4. Verify the entry shows up AND uses the title "About me" (not TESTING 123)

Part 2
5. Move mouse over the table data. Notice it stays as the cursor.
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
This was referenced Sep 24, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.2dev
Development

No branches or pull requests
5 participants
@diracdeltas @alexwykoff @luixxiul @bsclifton @srirambv