Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync reset progress marker release study - disable for investigations #66

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Sync reset progress marker release study - disable for investigations #66

merged 1 commit into from
Jun 22, 2021

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Jun 22, 2021 •
edited
Loading

Apply these values for ResetProgressMarkerOnCommitFailures feature
0% enabled, 100% disabled

for investigating sync server issues

CC @jsecretan , @hspencer77 , @yrliou

@AlexeyBarabash AlexeyBarabash self-assigned this Jun 22, 2021
@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner June 22, 2021 10:59
moritzhaller
moritzhaller reviewed Jun 22, 2021
View reviewed changes
seed/seed.json
],
"filter": {
"channel": ["NIGHTLY", "BETA", "RELEASE"],
"platform": ["WINDOWS", "MAC", "LINUX", "ANDROID"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: since this is enabled by default https://github.com/brave/brave-core/blob/06042dcf838745820a5448c4b66bdd017d14c54e/components/sync/engine/brave_model_type_worker.cc#L21 this PR won't disable on iOS (as we haven't rolled out variations to iOS)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I am not expecting lots of affected users on iOS

moritzhaller
moritzhaller approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

kjozwiak
kjozwiak approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved & Merged after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit da5ba3e into production Jun 22, 2021
AlexeyBarabash added a commit that referenced this pull request Jun 22, 2021
@AlexeyBarabash
Revert "Merge pull request #66 from brave/disable-sync-reset-progress…
b24e6e8 
…-release"

This reverts commit da5ba3e, reversing
changes made to 46d3b1f.
kjozwiak added a commit that referenced this pull request Jun 22, 2021
@kjozwiak
Merge pull request #69 from brave/revert_pr66
12ece60 
Revert "Merge pull request #66 from brave/disable-sync-reset-progress-release"
@AlexeyBarabash AlexeyBarabash deleted the disable-sync-reset-progress-release branch November 4, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritzhaller moritzhaller moritzhaller approved these changes

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@AlexeyBarabash AlexeyBarabash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexeyBarabash @moritzhaller @kjozwiak