Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Brave Ads idle time threshold #64

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

tmancey
Copy link
Contributor

@tmancey tmancey commented Jun 16, 2021

Fixes Brave Ads idle time threshold as the value represents a base::TimeDelta object. Default value is 15 seconds, changing to 5 seconds to increase ad delivery

@tmancey tmancey requested review from moritzhaller, iefremov, goodov and a team June 16, 2021 19:54
@tmancey tmancey self-assigned this Jun 16, 2021
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'll wait till we get a ++ from one of the dev reviewers before merging.

@tmancey
Copy link
Contributor Author

tmancey commented Jun 17, 2021

@iefremov @kjozwiak Thanks

@kjozwiak kjozwiak merged commit 46d3b1f into production Jun 17, 2021
@tmancey tmancey deleted the fix_brave_ads_idle_time_threshold branch June 23, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants