Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Blob partitioning until opaque origins fixed. #272

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

goodov
Copy link
Member

@goodov goodov commented Jun 3, 2022

Blobs from opaque origins doesn't work well with partitioning right now. Need to fix this. Until then disable the feature.

brave/brave-browser#23171

@goodov goodov requested a review from a team as a code owner June 3, 2022 05:58
@kjozwiak
Copy link
Member

kjozwiak commented Jun 3, 2022

Reproduced the original issue using 1.41.33 Chromium: 102.0.5005.78 where blob partitioning was enabled using the STR/Cases outlined via brave/brave-browser#23171.

image

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.39.111 Chromium: 102.0.5005.61 (Official Build) (64-bit)
-- | --
Revision | 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS | Windows 11 Version 21H2 (Build 22000.675)

Quickly went through the following to ensure that we're disabling DisableBlobPartitioning:

Example Example
image image

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved 👍 QA has verified the change via #272 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants