Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show opt-in page for decentralized DNS support in OTR contexts #8135

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Mar 5, 2021

Resolves brave/brave-browser#14488

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This is well covered by the new unit test, and the manual test plan is specified in the issue.

@yrliou yrliou added this to the 1.23.x - Nightly milestone Mar 5, 2021
@yrliou yrliou self-assigned this Mar 5, 2021
@yrliou yrliou marked this pull request as ready for review March 6, 2021 03:40
@yrliou yrliou requested a review from bbondy March 6, 2021 03:40
@yrliou
Copy link
Member Author

yrliou commented Mar 10, 2021

post-init failed with unrelated audit-dep error.

@yrliou yrliou merged commit 64d1ae8 into master Mar 10, 2021
@yrliou yrliou deleted the no_opt_in_otr branch March 10, 2021 18:18
yrliou added a commit that referenced this pull request Mar 18, 2021
Do not show opt-in page for decentralized DNS support in OTR contexts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not show opt-in page for decentralized DNS support in OTR contexts
2 participants