-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guardian api integration android #7904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
0414986
to
4abc421
Compare
Removing this from |
|
||
VpnService::VpnService(content::BrowserContext* context) | ||
: context_(context), | ||
url_loader_factory_( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|url_loader_factory_| is not used?
|
||
} // namespace | ||
|
||
VpnService::VpnService(content::BrowserContext* context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about making factory passing SharedURLLoaderFactory
instead of context
?
With it, we can remove content
dependency also.
base::WeakPtrFactory<VpnService> weak_factory_; | ||
base::WeakPtrFactory<VpnService> vpn_weak_factory_{this}; | ||
|
||
DISALLOW_COPY_AND_ASSIGN(VpnService); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This define is deprecated - https://source.chromium.org/chromium/chromium/src/+/main:base/macros.h;l=13
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory_; | ||
SimpleURLLoaderList url_loaders_; | ||
base::WeakPtrFactory<VpnService> weak_factory_; | ||
base::WeakPtrFactory<VpnService> vpn_weak_factory_{this}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to delete vpn_weak_factory_
JNIEnv* env, | ||
const base::android::JavaParamRef<jobject>& jcaller) { | ||
if (vpn_service_) { | ||
vpn_service_->GetAllServerRegions(base::Bind( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid base::Bind()
now. It's removed since C92.
and we also deleted all. - #8811
Closing this PR as i have created a new PR with updated changes here : #9131 |
Resolves brave/brave-browser#14048
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: