add welcome page favicon #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petemill
reviewed
Oct 2, 2018
| @@ -75,6 +75,7 @@ void CustomizeWebUIHTMLSource(const std::string &name, content::WebUIDataSource* | |||
| } | |||
| }, { | |||
| std::string("welcome"), { | |||
| { "ecaefa14dcf65df518730a336430727e.ico", IDR_BRAVE_WELCOME_FAVICON }, | |||
There was a problem hiding this comment.
Just a question here - why are we using these hashes for filenames and not the actual readable (and permanent) name? Presumably webpack can be configured to keep them?
There was a problem hiding this comment.
only because file-loader defaults file names to md5 hash. I guess this came from the boilerplate which was carried over from b-l and just lacks custom config.
webpack handles this via file-loader options by declaring name name: '[path][name].[ext]', but this seems to require changing all previous hashed files to their original names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes brave/brave-browser#584