Misc. minor Constellation P3A updates #18340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iefremov
reviewed
May 4, 2023
| @@ -71,7 +72,8 @@ void StarRandomnessPoints::SendRandomnessRequest( | |||
| randomness_request_state, | |||
| const rust::Vec<constellation::VecU8>& rand_req_points) { | |||
| auto resource_request = std::make_unique<network::ResourceRequest>(); | |||
| resource_request->url = GURL(config_->star_randomness_host + "/randomness"); | |||
| resource_request->url = | |||
| GURL(base::StrCat({config_->star_randomness_host, "/randomness"})); | |||
There was a problem hiding this comment.
there is not much profit in using strcat for two strings
There was a problem hiding this comment.
does it hurt? in terms of style, it seems like a better fit?
iefremov
reviewed
May 4, 2023
iefremov
reviewed
May 4, 2023
|
pls triple check all the |
DJAndries
force-pushed
the
star-p3a-misc-changes
branch
from
3bcbeff
to
dae6039
Compare
that's true. made some corrections |
DJAndries
force-pushed
the
star-p3a-misc-changes
branch
from
dae6039
to
401e17e
Compare
…ges in nitriding, cache attestation approved certificate fingerprint, replace DCHECKs with CHECKs
DJAndries
force-pushed
the
star-p3a-misc-changes
branch
from
401e17e
to
6cf744f
Compare
iefremov
approved these changes
May 8, 2023
kylehickinson
approved these changes
May 8, 2023
brave-builds
added a commit
that referenced
this pull request
May 8, 2023
7 tasks
25 tasks
kjozwiak
pushed a commit
that referenced
this pull request
May 12, 2023
Uplift of #18340 (squashed) to beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#30068
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Follow test plan that will soon be defined in #14399