Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper initialization of BraveShieldsHandler.mContext (uplift to 1.49.x) #17623

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Proper initialization of BraveShieldsHandler.mContext (uplift to 1.49.x) #17623

merged 1 commit into from
Mar 16, 2023

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Mar 15, 2023 •
edited by kjozwiak
Loading

Uplift of #17604
Resolves brave/brave-browser#28805

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@AlexeyBarabash AlexeyBarabash self-assigned this Mar 15, 2023
@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner March 15, 2023 18:11
@kjozwiak kjozwiak added this to the 1.49.x - Release #3 milestone Mar 16, 2023
kjozwiak
kjozwiak approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.49.x approved 👍 QA has verified the PR on Nightly as per #17604 (comment).

@kjozwiak kjozwiak merged commit 0fa26ac into 1.49.x Mar 16, 2023
@kjozwiak kjozwiak deleted the pr17604_cct_context_1.49.x branch March 16, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@AlexeyBarabash AlexeyBarabash

Labels
None yet
Projects
None yet
Milestone
1.49.x - Release #3
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexeyBarabash @kjozwiak