Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy keyboard shortcut is not assigned to 'copy clean link' in contex… #17487

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 6, 2023

Resolves brave/brave-browser#28891

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Steps from issue

@spylogsster spylogsster self-assigned this Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

⚠️ PR head is an unsigned commit
commit: e4ebc091ddc83e5dbbc43fda836fb7ca87c07be4
reason: unsigned
Please follow the handbook to configure commit signing
cc: @spylogsster

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

⚠️ PR head is an unsigned commit
commit: e4ebc091ddc83e5dbbc43fda836fb7ca87c07be4
reason: unsigned
Please follow the handbook to configure commit signing
cc: @spylogsster

@spylogsster spylogsster marked this pull request as ready for review March 6, 2023 16:32
@spylogsster spylogsster merged commit 8b744ad into master Mar 7, 2023
@spylogsster spylogsster deleted the brave-28891 branch March 7, 2023 13:34
@github-actions github-actions bot added this to the 1.51.x - Nightly milestone Mar 7, 2023
@AustinGitHub
Copy link

Question, is this a fix for this issue I just opened up? brave/brave-browser#29074 I am trying to find the source for why it was decided to change the keyboard shortcut to "copy clean link" automatically for users, this is a major regression as it disturbs the actual functionality of using copy/paste, thanks!

@LaurenWags
Copy link
Member

Verified with

Brave	1.51.37 Chromium: 111.0.5563.64 (Official Build) nightly (64-bit) 
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	Linux

Verified STR from description.
Confirmed context menu displayed "Ctrl + C" next to "Copy clean link".

Screen Shot 2023-03-16 at 9 00 28 AM

kjozwiak pushed a commit that referenced this pull request Mar 20, 2023
…… (uplift to 1.50.x) (#17607)

Uplift of #17487 (squashed) to beta
kjozwiak pushed a commit that referenced this pull request Mar 20, 2023
……(uplift #17487) (#17610)

Copy keyboard shortcut is not assigned to 'copy clean link' in contex… (#17487)
@bsclifton bsclifton deleted the brave-28891 branch March 22, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy keyboard shortcut is not assigned to "copy clean link" in context menu on Linux
5 participants