Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI on draft PRs by default #17430

Merged
merged 7 commits into from
Mar 7, 2023
Merged

Run CI on draft PRs by default #17430

merged 7 commits into from
Mar 7, 2023

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Mar 1, 2023

Resolves https://bravesoftware.slack.com/archives/C7VLGSR55/p1665996259388159

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@wknapik wknapik self-assigned this Mar 1, 2023
@wknapik wknapik added CI/skip Do not run CI builds (except noplatform) CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows CI/skip-ios Do not run CI builds for iOS and removed CI/skip Do not run CI builds (except noplatform) CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows CI/skip-ios Do not run CI builds for iOS labels Mar 1, 2023
@wknapik wknapik force-pushed the wknapik-run-ci-on-drafts-by-default branch from 47ee343 to 3b4fcc2 Compare March 7, 2023 11:08
@wknapik wknapik marked this pull request as ready for review March 7, 2023 11:08
@wknapik wknapik requested a review from a team as a code owner March 7, 2023 11:08
@wknapik wknapik force-pushed the wknapik-run-ci-on-drafts-by-default branch from 3b4fcc2 to 7c65cce Compare March 7, 2023 13:13
@wknapik wknapik requested a review from bsclifton as a code owner March 7, 2023 13:13
@mihaiplesa mihaiplesa merged commit 3a8eaef into master Mar 7, 2023
@mihaiplesa mihaiplesa deleted the wknapik-run-ci-on-drafts-by-default branch March 7, 2023 13:20
@github-actions github-actions bot added this to the 1.51.x - Nightly milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaiplesa mihaiplesa mihaiplesa approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton bsclifton is a code owner

Assignees

@wknapik wknapik

Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@wknapik @mihaiplesa