-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: password-protect account private key reveal #14390
fix: password-protect account private key reveal #14390
Conversation
components/brave_wallet_ui/components/desktop/popup-modals/account-settings-modal/index.tsx
Fixed
Show fixed
Hide fixed
A Storybook has been deployed to preview UI for the latest push |
c80d411
to
ed10f6b
Compare
A Storybook has been deployed to preview UI for the latest push |
fa81383
to
a9e8f40
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - spotted one non-blocking thing to consider adding also.
As far as the design goes, it seems like it could be useful to allow the user to disable this as well with a settings toggle (assuming they've verified their password first), but I don't think that's something that should block this from going forward. Is that something worth considering here as well @jamesmudgett ?
..._wallet_ui/components/desktop/popup-modals/account-settings-modal/account-settings-modal.tsx
Show resolved
Hide resolved
3e64ca4
to
7cfa50a
Compare
A Storybook has been deployed to preview UI for the latest push |
Resolves brave/brave-browser#24322
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
6a. Error message appears if incorrect password was entered
6b. Key is displayed if correct password was entered