Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): use hex-encoded blockCount param for eth_feeHistory #14088

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

onyb
Copy link
Member

@onyb onyb commented Jul 8, 2022

Resolves brave/brave-browser#23529

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Checking known RPC endpoints to see if they support hex-encoded blockCount param to eth_feeHistory RPC method:

curl -s <url> -X POST -H "Content-Type: application/json" -d '{"id":1,"jsonrpc":"2.0","method":"eth_feeHistory","params":["0x28", "latest", [20,50,80]]}' | jq
RPC Name RPC Endpoint Supports hex blockCount
Ethereum (Brave) https://mainnet-infura.brave.com
Polygon (public) https://polygon-rpc.com
Polygon (Brave) https://mainnet-polygon.brave.com
Avalanche C-Chain (public) https://api.avax.network/ext/bc/C/rpc
Fantom (public) https://rpc.ftm.tools
Moonbeam (public) https://rpc.ankr.com/moonbeam

Optimism, Celo, BSC, and Aurora (NEAR) not included in the above table, since they do not support EIP-1559.

Please see linked issue for steps to reproduce for Moonbeam.

@onyb onyb requested a review from bbondy July 8, 2022 13:43
@onyb onyb requested a review from a team as a code owner July 8, 2022 13:43
@onyb onyb self-assigned this Jul 8, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.43.12 Chromium: 103.0.5060.114 (Official Build) nightly (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Windows 11 Version 21H2 (Build 22000.778)
14088.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to complete Moonbeam transactions (Gas estimation fails)
3 participants