Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Sync Phase v2 TimeLimited Uplift - 1.40.x #13513

Closed
wants to merge 1 commit into from

Conversation

Brandon-T
Copy link
Contributor

Uplift of: #13483

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added this to the 1.40.x - Beta milestone May 27, 2022
@Brandon-T Brandon-T requested a review from a team May 27, 2022 16:58
@Brandon-T Brandon-T requested a review from a team as a code owner May 27, 2022 16:58
@Brandon-T Brandon-T self-assigned this May 27, 2022
@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels May 27, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Jun 2, 2022

Closing the above as #12300 is not being uplifted into 1.40.x & 1.39.x via #13533 & #13536 as discussed via Slack. However, we'll need to uplift #13574 into 1.40.x so we don't run into issues where users attempt to use the new time-limited backup codes in 1.40.x which won't have #12300 when we do channel migrations on June 14, 2022.

@kjozwiak kjozwiak closed this Jun 2, 2022
@kjozwiak kjozwiak deleted the ios/sync-phase-v2-1.40.x branch June 2, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants