Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip disconnection message on mac #13504

Merged
merged 2 commits into from
May 30, 2022
Merged

Do not skip disconnection message on mac #13504

merged 2 commits into from
May 30, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented May 27, 2022

Resolves brave/brave-browser#22883

On mac we should not skip disconnection message, seems forgot to wrap code to be win-only. This PR fixes only infinite connection view. Specific error view will be added as requested in brave/brave-browser#22754

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable VPN (see test plan in Implement Brave VPN on Desktop brave-browser#15804 for more information)
  2. Click VPN button (next to hamburger menu) and connect to a server
  3. Disconnect your network (if plugged in with ethernet unplug, if on WiFi disable)
  4. Click VPN button again - it should be trying to reconnect
  5. It should stop immediately and show disconnection status

@spylogsster spylogsster self-assigned this May 27, 2022
@spylogsster spylogsster added this to the 1.41.x - Nightly milestone May 27, 2022
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

components/brave_vpn/brave_vpn_service.cc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPN connect / reconnecting may not have a proper timeout
2 participants