Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFT Details Screen #13370
NFT Details Screen #13370
Changes from all commits
171587a
3307d5d
4d89cef
ae18fd0
7afba29
5cb0546
f7ee226
87d5098
94f8730
08d38a0
022337f
36397a0
59c1f24
9356802
413f2e6
0a2cddf
d20d0eb
0d545d2
03b1c13
6fb2526
77d3bfe
fe01c95
c06ec88
f1da324
756264a
2128cea
7c3d68a
200efb9
e2ce2fa
995aa0b
73b9bed
cc371f1
001785c
7e279e6
70b43bb
f3e8d2b
7eb7b05
8549236
0a570f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: do we need the trezor bridge URL here? just making sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @kdenhartog since he's been working on cleaning up the CSP a bit in wallet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we would be loading HTTPS URLs directly here instead of via
chrome
. is that the expected behavior?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think if we are loading these logos in webui they should generally be passed through this sanitizer https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/webui/sanitized_image_source.h?q=chrome:%2F%2Fimage&ss=chromium